Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run terraform plugin for all terraform state commands (not just `stat… #476

Merged
merged 1 commit into from
Nov 13, 2024
Merged

run terraform plugin for all terraform state commands (not just `stat… #476

merged 1 commit into from
Nov 13, 2024

Conversation

frans-otogone
Copy link

Overview

This PR makes sure the terraform plugin is run for all terraform state commands.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

Run terraform state show '<any terraform resource id in your state>' or terraform state pull|push`.

Changelog

The terraform plugin now kicks in on all terraform state subcommands, not just terraform state list.

SimonBarendse
SimonBarendse approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @frans-otogone !

Makes sense to me: both terraform state list and terraform state show require authentication.

@frans-otogone
Copy link
Author

Any chance we could get this merged in the near future?

@SimonBarendse SimonBarendse merged commit 2a7d404 into 1Password:main Nov 13, 2024
3 checks passed
@SimonBarendse
Copy link
Member

Apologies for the delay on this @frans-otogone ! This will go out with the next 1Password CLI release.

@frans-otogone frans-otogone deleted the terraform-plugin-include-all-state-commands branch November 14, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hculea hculea hculea approved these changes

@SimonBarendse SimonBarendse SimonBarendse approved these changes

@Marton6 Marton6 Awaiting requested review from Marton6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frans-otogone @SimonBarendse @hculea